Colin Alworth has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
......................................................................
Patch Set 6:
Thanks Goktug - one of the distinct advantages of extending Element is that
we can subclass UiObject.getElement and already have access to the methods
we want, and on the other side the subclass can invoke Element methods
(without the pretend-jso-cast). As I understand it, from your example,
GxtElement is superfluous - we'd need to .cast() to GxtElement to even get
the .cast() method to get GxtExtensions ;).
(wrapping up, as Andrey's code review probably isn't the place...) W.R.T.
devirtualization, that doesn't quite go far enough - constructors do not go
away, and the this$static is still needed, even though it is only to grab
the one field inside it. And while v8 might do the alias analysis and drop
the ctor, I'm all by certain that IE6-9 don't (and 10 would be a guess).
--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy <[email protected]>
Gerrit-Reviewer: Colin Alworth <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
