Goktug Gokdogan has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Looks good to me API wise.
....................................................
File user/src/com/google/gwt/event/dom/client/KeyCodes.java
Line 442: * @param code the keycode to check
nit: space before @param?
Line 443: * @return true if the keycode matches an arrow key
{@code true}
BTW, perhaps you should remove @param's here. It doesn't add much and also
you are not being consistent by not adding to those to maybeSwap...
Line 458: * Update arrow keys for left and right based on current locale.
It might be a good idea to put a short code snippet here to show intended
usage.
--
To view, visit https://gwt-review.googlesource.com/3662
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I811520d330c181958dd67cbfbe30c46becebbe43
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
