Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
......................................................................
Patch Set 5: Code-Review+1
(3 comments)
Nits only (I'd still add an "experimental" note to maybeSwap; "this method
is used internally by built-in GWT widgets but could be renamed/refactored
without notice" – I put "refactored" because I think @jat would be OK with
I18N being part of "core", so we could re-add the dependency from c.g.g.dom
to c.g.g.i18n that you initially had, this has to be discussed further
though)
....................................................
File user/src/com/google/gwt/event/dom/client/KeyCodes.java
Line 460: * int keyCode = DOM.eventGetKeyCode(event);
Unused: line below uses event.getKeyCode() (which should be preferred to
DOM.eventGetKeyCode(event) anyway)
Line 462: * keyCode =
KeyCodes.maybeSwapArrowKeysForRtl(event.getKeyCode(), isRtl);
As I said earlier, I'd merge the 2 above lines:
int keyCode = KeyCodes.maybeSwapArrowKeysForRtl(event.getKeyCode(),
LocaleInfo.getCurrentLocale().isRTL());
Line 465: * ... // no special RTL handling
Hint about "start of line" for "left" and "end of line" for "right" in
those comments?
--
To view, visit https://gwt-review.googlesource.com/3662
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I811520d330c181958dd67cbfbe30c46becebbe43
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
