Thomas Broyer has posted comments on this change.

Change subject: Move arrow key functions from Tree to KeyCodes
......................................................................


Patch Set 5:

(1 comment)

....................................................
File user/src/com/google/gwt/event/dom/client/KeyCodes.java
Line 465:    *     ... // no special RTL handling
When you swap a KEY_RIGHT for a KEY_LEFT in RTL, that's because you're interested in the "start of the line" (which is on the left in LTR) rather than the left vs. right; so in the "case KEY_LEFT", the comment could say "start of the line, no special RTL handling".


--
To view, visit https://gwt-review.googlesource.com/3662
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I811520d330c181958dd67cbfbe30c46becebbe43
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to