On Tuesday, November 12, 2013 5:37:36 PM UTC+1, Cristiano wrote: > > 2013/11/12 Jens <[email protected] <javascript:>> > >> Just wanted to throw in that if you use GWT's remote logging along with >> source maps then the StackTraceDeobfuscator also needs some classes from >> gwt-servlet-deps. As I think it's a pretty common scenario nowadays to >> enable source maps where possible you maybe should handle this case as >> well. IMHO everything in gwt-servlet-deps that is found under the package >> com.google should go into gwt-servlet. Doesn't really makes sense to me to >> have these classes in a jar that is not deployed to maven. >> > > > At first I've read "everything in gwt-servlet-deps should go into > gwt-servlet" and I was against that... > ...then I've read it better the "that is found under the package > com.google" and yes I agree!! > > You basically means that if something in gwt-servelt-deps has been rebased > then it should go into gwt-servlet and I am okay with this! > > Alternatively I think it is better to split gwt-servlet-deps into 2, for > example: > - gwt-servlet-deps-external.jar > - gwt-servlet-deps-rebased.jar >
No, if it's been rebased, it's safe to include in gwt-servlet (for Maven, for example), and I don't see any reason for putting it in another JAR. If it's been rebased, it's become an "internal" API of GWT. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
