Sounds like a reasonable proposal to me.
On Wed, Nov 13, 2013 at 9:33 AM, Thomas Broyer <[email protected]> wrote: > > > On Wednesday, November 13, 2013 5:41:12 PM UTC+1, Cristiano wrote: >> >> Hi All, >> >> I then think that it is needed a patch to include guava-15.0-rebased.jar, >> sourcemap-rebased.jar, protobuf-java-rebased-2.5.0.jar and >> streamhtmlparser-jsilver-r10-1.5-rebased.jar in gwt-servlet.jar >> > > No, not protobuf, it's only used for DevMode's "remote UI" (what makes the > Dev Mode view in Eclipse possible) > > Guava is only needed for SafeHtml and SafeUri, so it'd be better to > provide guava-less implementation of the two classes that use it; except if > it's also needed for sourcemap, in which case it's OK to put it into > gwt-servlet. > > >> The patch should be as easy as moving the following lines in >> servlet/build.xml up within the <gwt.jar> task of "-servlet" target: >> <zipfileset src="${gwt.tools.lib}/guava/ >> guava-15.0/guava-15.0-rebased.jar" /> >> <zipfileset src="${gwt.tools.lib}/jscomp/ >> 20131014/sourcemap-rebased.jar" /> >> <zipfileset src="${gwt.tools.lib}/protobuf/protobuf-2.5.0/ >> protobuf-java-rebased-2.5.0.jar" /> >> <zipfileset src="${gwt.tools.lib}/streamhtmlparser/ >> streamhtmlparser-jsilver-r10/streamhtmlparser-jsilver-r10-1.5-rebased.jar" >> /> >> >> else, people may be deploying GWT web application without being able to >> make them work. >> >> Make the patch is easy, get the contributors to take a final decision is >> harder: >> but I think that the problem should be solved for 2.6.0 as Validation is >> a feature described in the GWT dev guide (http://www.gwtproject.org/ >> doc/latest/DevGuideValidation.html) and the problem is there since gwt >> 2.5 (I would not be surprised if no one use that feature). >> >> So, what you do think? >> > > I'd support such a change, and cherry-picking it to the release/2.6 branch! > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > --- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
