Ok, I'll follow your indications, I'll give it a try before pushing it and in case of surprises I'll come back here to discuss.
Do you want me also to create an issue associated to this, for tracking purposes? Cristiano Il giorno mercoledì 13 novembre 2013, Roberto Lublinerman ha scritto: > > > > On Wed, Nov 13, 2013 at 9:33 AM, Thomas Broyer > <[email protected]<javascript:_e({}, 'cvml', '[email protected]');> > > wrote: > >> >> >> On Wednesday, November 13, 2013 5:41:12 PM UTC+1, Cristiano wrote: >>> >>> Hi All, >>> >>> I then think that it is needed a patch to include >>> guava-15.0-rebased.jar, sourcemap-rebased.jar, >>> protobuf-java-rebased-2.5.0.jar >>> and streamhtmlparser-jsilver-r10-1.5-rebased.jar in gwt-servlet.jar >>> >> >> No, not protobuf, it's only used for DevMode's "remote UI" (what makes >> the Dev Mode view in Eclipse possible) >> >> Guava is only needed for SafeHtml and SafeUri, so it'd be better to >> provide guava-less implementation of the two classes that use it; except if >> it's also needed for sourcemap, in which case it's OK to put it into >> gwt-servlet. >> > > Guava is used by sourcemap so it must be provided as well. > > @Cristiano would you want to make the patch yourserf? If so just add me as > a reviewer.... > > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > --- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to > [email protected]<javascript:_e({}, > 'cvml', > 'google-web-toolkit-contributors%[email protected]');>. > For more options, visit https://groups.google.com/groups/opt_out. > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
