As I was writing a memo about the issue, it happened to me that there could be an easy workaround: special-case org.eclipse.jetty. classes to allow loading them from the system classloader as a fallback, without adding the containing classpath entry (most likely gwt-dev.jar) to the webapp classloader.
That said, given that some users don't understand the warning (https://groups.google.com/d/topic/google-web-toolkit/GSKlMwFKh3c/discussion), I'm tempted to refactor the classloading logic anyway, but possibly for GWT.next (leaving only the small workaround in 2.6.1). BTW, I think we also need to refactor the InstalledHelpInfo to possibly link to the same files hosted at gwtproject.org; the issue here being that there could be a discrepancy between the version of GWT being used and the doc hosted at gwtproject.org (which would always be for the latest stable version; what about RCs? trunk/master? we could possibly just have a header in the docs saying for which version they apply to, and that they might not apply to other versions of GWT). The problem with InstalledHelpInfo as done currently is that it only links to additional doc if you use the SDK, but nowadays many people use dependency managers (Maven, Gradle, Ivy, etc.) so they don't have the additional info that could help them better understand the problem(s). On Tuesday, March 11, 2014 3:55:41 AM UTC+1, Goktug Gokdogan wrote: > > To be honest I don't even understand full extend of the problem, I mostly > followed what is already there. We don't use most of this stuff internally. > > I trust you making the best choice for external users and I'm fine with it > as long as it doesn't break internal users. > > > On Sat, Mar 8, 2014 at 5:12 PM, Thomas Broyer <[email protected]<javascript:> > > wrote: > >> >> >> On Sunday, March 9, 2014 1:09:23 AM UTC+1, Thomas Broyer wrote: >>> >>> Hi all, >>> >>> The update from Jetty 6 to Jetty 8 wasn't without regressions. One of >>> them is a classloader issue. >>> >>> First, when starting DevMode, sometimes (IIRC, not for all projects, >>> might be because I tried with a WEB-INF/jetty-web.xml), it starts with: >>> >>> [WARN] Server resource 'org/eclipse/jetty/xml/configure_6_0.dtd' could >>> not be found in the web app, but was found on the system classpath >>> [WARN] Adding classpath entry 'file:/home/tbr/.m2/ >>> repository/com/google/gwt/gwt-dev/2.6.0/gwt-dev-2.6.0.jar' to the web >>> app classpath for this session >>> >>> Which is… bad! (it's gwt-dev.jar here!) >>> and is btw probably the cause of https://code.google.com/p/ >>> google-web-toolkit/issues/detail?id=8526 (the other known regression) >>> >> >> Tried the "Hello" sample, it starts with: >> >> [WARN] Server class 'org.eclipse.jetty.servlet.listener.ELContextCleaner' >> could not be found in the web app, but was found on the system classpath >> [WARN] Adding classpath entry >> 'file:/C:/Users/MRO/Downloads/gwt-2.6.0/gwt-2.6.0/gwt-dev.jar' to the web >> app classpath for this session >> For additional info see: >> file:/C:/Users/MRO/Downloads/gwt-2.6.0/gwt-2.6.0/doc/helpInfo/webAppClassPath.html >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors >> --- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to >> [email protected]<javascript:> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
