On Tue, Mar 18, 2014 at 4:10 PM, Stephen Haberman < [email protected]> wrote:
> > > Neither one (depending on your build tool though). > > Sure, I get that Maven/Gradle/Ant will go through a copy-to-target step > first, and so not use any src/... artifacts. So, for them, having the > Jetty classloader not use the project classpath makes sense. > > But at least we way run DevMode in Eclipse (as vanilla .launch files > with DevMode as the main class), we pass -war src/main/webapp, so we > can run directly against src/ without any copy-to-target/build system > steps at all. > > And so then all of our IvyDE-managed jars and project .class files come > from the regular Eclipse/system classpath that "Java Applications" get. Writing to a source dir still feels hideously bad to me, but that's your project and I'm not going to dictate the way you should do it (and neither should GWT) > I don't have a strong opinion though; I'd be fine just using the > > system classloader as the parent of the webapp classloader (the end > > result would be the same as if you deployed all your code and > > dependencies to Jetty's lib/ or lib/ext/ or Tomcat's shared/ ); > > Which is the behavior today, right? No. Today, the parent classloader only contains bootstrap classes. But the webapp classloader will automatically add JARs/directories to the webapp classloader if the webapp tries to load a class that cannot be found in either WEB-INF/ or the JVM (and you should have a warning that it couldn't find the class in the webapp but found it in the system classpath and that it adds the given JAR/directory to the webapp for the current session). What I'm proposing in the end of the memo is to allow this kind of things (with or without the warning) if we cannot compute the GWT SDK install path (i.e. you likely use managed dependencies); but if you use the GWT SDK (and thus probably do not use managed dependencies), then we should probably mandate that you put everything within your WEB-INF (the GPE already automatically configures Eclipse to output classes to WEB-INF/classes). AFAICT, the GPE doesn't integrate with Ivy, so should I understand that you're not using the GPE? or are you adding the GWT SDK as a dependency to your Eclipse project? or you just configured the GPE to not warn about a "missing SDK"? > > > I think newbies would need/prefer warnings. > > I'd be fine with a warning that could be disabled... :-) > You already have it ;-) …but with different semantics. (disable by setting the gwt.nowarn.webapp.classpath system property to any value) -- Thomas Broyer /tɔ.ma.bʁwa.je/ <http://xn--nna.ma.xn--bwa-xxb.je/> -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
