On Sunday, March 9, 2014 3:02:31 PM UTC+1, Jens wrote: > > In the end, I wonder if we shouldn't just basically revert >> https://code.google.com/p/google-web-toolkit/source/detail?r=4944, >> except issuing a warning when we find the class in the system classpath >> (but without automatically adding the JAR to the classpath and instead just >> saying they should move it to WEB-INF/lib). Maybe we could add a switch (in >> the form of a system property) to allow loading from the system classloader >> (not restricted to Jetty system and server classes). >> >> What do you think? >> > > IMHO embedded jetty should behave like any other production server. If > something is missing in WEB-INF/lib and is not provided by the server > itself it should fail. And if people have production servers that provide > additional API's (that shouldn't be in WEB-INF/lib) they should use > -noserver instead. >
+1 The problem is determining what "provided by the server" actually means though. Servers generally just use their classpath, but in our case the classpath generally (because of Eclipse, and because of how DevMode loads client code too) contains the classes that also are in WEB-INF/lib, so delegation to the "server classpath" just won't work (or rather, it'll work "too well", and won't detect that "something is missing in WEB-INF/lib". I've written a memo on the issue, and possible solutions: https://docs.google.com/document/d/1bWfafaPA0m0Z1Swodnx7m3QTv31OdqFkE7aeadN_2BU/edit?usp=sharing It's still work in progress re. the solutions. I have a sent a patch re. the first solution: https://gwt-review.googlesource.com/6651 Still testing it a bit but sounds promising for inclusion in 2.6.1. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
