I think this is a reasonable change to make since it's simple to implement and a noticeable improvement for SVN users. I'll go ahead and get it in and we can cherry pick it into this release.
On Tue Oct 21 2014 at 5:58:00 AM Juan Pablo Gardella < [email protected]> wrote: > Thanks for sharing Jérémie. Good to know. > > On 21 October 2014 09:32, Jérémie Gottero <[email protected]> > wrote: > >> Do we have an easy way to exclude these folders to see if it improves >>> things? >>> >> >> Quick and dirty: I overrode the descendToFindResources method to exclude >> .svn files (note that the file is excluded before isDirectory/isFile calls, >> avoiding an extra i/o): >> >> File[] children = dir.listFiles(); >> for (File child : children) { >> if (child.getName().equals(".svn")) // hardcoded filter here >> continue; >> String childPath = dirPath + child.getName(); >> if (child.isDirectory()) { >> >> Reload time goes down from 2,8s to 1,1sec. The ability to filter files >> here could lead to interesting speed improvements. >> >> Another possible improvement: I got 4874 calls to file.lastModified() in >> a single browser refresh, for 2088 unique files. Caching the result per run >> could avoid 50% i/o and reload time would go below 1s. I have no idea if >> it's realistic/easy to do though, I havent dug in the code ;) >> >> -- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/google-web-toolkit-contributors/b052327f-8538-4598-b4fb-740cd16d2deb%40googlegroups.com >> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/b052327f-8538-4598-b4fb-740cd16d2deb%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/CA%2BkiFse_4M3ZqrOa2D%2BdQfVhmWvxXABFH7F7y-KkNXKu5HLxcA%40mail.gmail.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/CA%2BkiFse_4M3ZqrOa2D%2BdQfVhmWvxXABFH7F7y-KkNXKu5HLxcA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAFw3gJ9neWoGRV-ZRwWBSn-8aMo4WnabdK73ooL%2B0o_kXTpuPQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
