http://bugs.gpodder.org/show_bug.cgi?id=259
--- Comment #2 from Cory Albrecht <[EMAIL PROTECTED]> 2008-11-24 02:14:00 --- Thomas: If I understand you correctly, you're saying that gpodder uses the url attribute of the enclosure tag to determine uniqueness/already-seen-ness of an episode listed in a feed. Caveats: I do not know python, nor have I looked at the gpodder code until just now. It looks to me that in databse.py, the function load_episode (line 325) is the code that is responsive for determining if an episode has already been seen and downloaded. If you change the constraint from 'where url = ?' to 'where guid = ?' just to make the feed I gave work because then in the scenario that you gave - guid staing teh same but url changes each time - that would only suffer the same problem that I am encountering. But what if you used 'where (url = ?) && (guid = ?)' as the constraint? That would not break the hypothetical feed/channel you describe where the guid is always the same. It would reduce to 'where (url = ?) && TRUE' because the guid parameter is alway going to be the same for each item entry in the feed. Something && TRUE == Something, as if the && TRUE wasn't there. The only downside, if you even consider it one, is adding an extra parameter to load_episode() function and making sure you remember to update it where ever it is called. (I hate it when I forget that! :-) ) Of course, as per the caveat, I could be completely wrong about section of code actually responsible for doing this checking, but even in that case I believe I would still be right about the basic idea of simply adding a constraint to the WHERE clause in the appropriate SQL statement that would not break anything else. -- Configure bugmail: http://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
