http://bugs.gpodder.org/show_bug.cgi?id=340





--- Comment #8 from Nick <[email protected]>  2009-04-21 04:30:27 ---
(In reply to comment #6)
> Is the fact that old episodes are purged the only symptom or one of a few
> symptoms of making old episodes appear as new? If so, maybe we should have 
> some
> kind of "already seen" list that only contains URLs and GUIDs and if a new
> episode appears, it is checked against that list in order to mark the episodes
> as not new.
> 
> Comments on this?

I think there's a simpler solution. Move "db.purge(..." right before the
"db.commit()" (near the end of the function). I don't really understand why it
wasn't put there in the first place, the reason given in the comments doesn't
have me convinced that the purge must happen before the update.

Another way to fix this would be to force any *new* (ie. not in gPodder's
cache) episode with a pubDate that's older than the newest episode to be marked
as being "old".

This fixes part of the problem (the one reported in the initial bug report) but
does not address the cause. The reason this is happening on certain feeds is
because, as I mentioned above, the feed authors decided to change all of their
GUIDs. This results in duplicate episodes listed in gPodder (the second part of
the problem). The easiest way I can think of to solve this is when updating,
instead of just comparing GUIDs, we should also check to see if the podcast's
on-disk filename is unique. Or perhaps title checking, I'm not sure what would
be the most reliable way to do this...

-- 
Configure bugmail: http://bugs.gpodder.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
gPodder-Bugs mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-bugs

Reply via email to