https://bugs.gpodder.org/show_bug.cgi?id=553

--- Comment #21 from [email protected] 2010-10-13 22:25:52 BST ---
(In reply to comment #20)
> (In reply to comment #19)
> 
> I wrote:
> > (In reply to comment #18)
> > > Merged, thanks: http://gpodder.org/commit/80d9fd7d
> > 
> > This change breaks icons on KDE 3.3 in the way described in Comment 10. 
> > Backing out this change fixes this back to normal.
> 
> Oops, I meant KDE 3.5 (rather than 3.3).

I though that nobody were still using kde3, or at least kde3 with a recent
gpodder build.

In KDE4 there is a envivonment variable 'KDE_SESSION_VERSION' which value is 4.
I think that 'KDE_SESSION_VERSION' is not available in KDE3 and that
'KDE_FULL_SESSION' is not available prior KDE3.5.5

That said, something like:
if 'KDE_FULL_SESSION' in os.environ and 'KDE_SESSION_VERSION' in os.environ:
would do the job assuming that 'KDE_SESSION_VERSION' is not in KDE3, if it is,
we will have to check the value.

sideral, can you confirm if that variable is set?


(In reply to comment #17)
> emblem-new is now available on KDE, so ICON_UNPLAYED doesn't need to be
> replaced

Here I assumed that somebody using the last version of gpodder would use the
last version of KDE. If that is not the case and an older KDE version is being
used, I guess that you won't see some of the icons.

-- 
Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
gPodder-Bugs mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-bugs

Reply via email to