On 2016-01-14 11:59 AM, Élie Roux wrote:
You can completely discard it, I realized too late I was going in the
wrong direction, and gave it up. There are a few things that could be
kept though, such as

https://github.com/gregorio-project/gregorio/commit/73f3ec3e9443c814373f20255333c3f9cd66e372

Kept.

https://github.com/gregorio-project/gregorio/commit/a11c5e612b280c7dcf33ff16b456f9b4b21a1eb4

and

https://github.com/gregorio-project/gregorio/commit/20768eeb37acc644c1a1a3988905f51ea7393500

These implement a style for the commentary field. I don't disapprove of this, but I feel that if the commentary field has a style associated with it, shouldn't the annotation as well? Especially after my rewrite, which makes \grecommentary very similar to \greannotation in its functionality, I feel like there should be some consistency here.

If others feel the styles are worth including, then I can add both before submitting my PR.


✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝
Br. Samuel, OSB
St. Anselm’s Abbey
Washington, DC
(R. Padraic Springuel)

PAX ☧ ΧΡΙΣΤΟΣ

_______________________________________________
Gregorio-devel mailing list
[email protected]
https://mail.gna.org/listinfo/gregorio-devel

Répondre à