Thankyou Paolo and Shunwan for your input.
With the extra details about the errata 7703, that was provided below, I see 
your point very clearly.

I will add new counters for rib-in-pre-policy as mentioned by Shunwan below.

Thanks
Mukul



Juniper Business Use Only
From: Paolo Lucente <[email protected]>
Date: Sunday, January 21, 2024 at 9:06 PM
To: Zhuangshunwan <[email protected]>, Mukul Srivastava 
<[email protected]>, Job Snijders <[email protected]>, [email protected] 
<[email protected]>
Subject: Re: [GROW] Working Group Call for draft-msri-grow-bmp-bgp-rib-stats 
(start 06/Dec/2023 end 06/Jan/2024)
[External Email. Be cautious of content]


Hi Mukul,

I would like to express +1 to Shunwan request. A few more thoughts,
including where the request comes from are captured in this previous
email thread about errata 7703:
https://urldefense.com/v3/__https://mailarchive.ietf.org/arch/msg/grow/nQm-lyKSZSaSdIhUQlTa6n-U0tA/__;!!NEt6yMaO-gk!BgWI055OLz5BkhuhpOdOlZSgAgm1tWKlhAMrUM1xQnUqysGknt40nLSy2b368miqAB8uK_r_DQ$<https://urldefense.com/v3/__https:/mailarchive.ietf.org/arch/msg/grow/nQm-lyKSZSaSdIhUQlTa6n-U0tA/__;!!NEt6yMaO-gk!BgWI055OLz5BkhuhpOdOlZSgAgm1tWKlhAMrUM1xQnUqysGknt40nLSy2b368miqAB8uK_r_DQ$>

Paolo


On 20/01/2024 03:45, Zhuangshunwan wrote:
> Hi Mukul,
>
> I have read draft-ietf-grow-bmp-bgp-rib-stats-00 and I think the
> description in your document is very clear and accurate. I think it's
> great to explicitly define Stat Type 7 and Stat Type 9 as counters for
> rib-in-pre-policy and also define counters for rib-in-post-policy.
>
> Thanks,
>
> Shunwan
>
> *From:*Mukul Srivastava [mailto:[email protected]]
> *Sent:* Friday, January 19, 2024 11:01 PM
> *To:* Zhuangshunwan <[email protected]>; Job Snijders
> <[email protected]>; [email protected]
> *Subject:* Re: [GROW] Working Group Call for
> draft-msri-grow-bmp-bgp-rib-stats (start 06/Dec/2023 end 06/Jan/2024)
>
> Hi Shunwan
>
> I looked at your proposed counter and I feel that they are already
> present in RFC 7854 for rib-in-pre-policy.
>
> Copying it here from RFC 7854.
>
> *4.8 
> <https://urldefense.com/v3/__https://www.rfc-editor.org/rfc/rfc7854.html*section-4.8__;Iw!!NEt6yMaO-gk!BgWI055OLz5BkhuhpOdOlZSgAgm1tWKlhAMrUM1xQnUqysGknt40nLSy2b368miqAB8VyMdHlQ$
>  >.  Stats
> Reports*
>
>    o  Stat Type = 7: (64-bit Gauge) Number of routes in Adj-RIBs-In.
>
>     o  Stat Type = 9: Number of routes in per-AFI/SAFI Adj-RIB-In.  The
>
>        value is structured as: 2-byte Address Family Identifier (AFI),
>
>        1-byte Subsequent Address Family Identifier (SAFI), followed by a
>
>        64-bit Gauge.
>
> For rib-in-post-policy, we don’t have those counters and can be added. I
> will add them.
>
> Let me know if you have any further comments.
>
> Thanks
>
> Mukul
>
> Juniper Business Use Only
>
> *From: *Mukul Srivastava <[email protected] <mailto:[email protected]>>
> *Date: *Wednesday, January 17, 2024 at 9:15 AM
> *To: *Zhuangshunwan <[email protected]
> <mailto:[email protected]>>, Job Snijders
> <[email protected]
> <mailto:[email protected]>>, [email protected]
> <mailto:[email protected]> <[email protected] <mailto:[email protected]>>
> *Subject: *Re: [GROW] Working Group Call for
> draft-msri-grow-bmp-bgp-rib-stats (start 06/Dec/2023 end 06/Jan/2024)
>
> Thanks for the comments.  I will go over it and update docs accordingly.
>
> Thanks
>
> Mukul
>
> *From: *GROW <[email protected] <mailto:[email protected]>> on
> behalf of Zhuangshunwan <[email protected]
> <mailto:[email protected]>>
> *Date: *Saturday, December 9, 2023 at 3:27 AM
> *To: *Zhuangshunwan <[email protected]
> <mailto:[email protected]>>, Job Snijders
> <[email protected]
> <mailto:[email protected]>>, [email protected]
> <mailto:[email protected]> <[email protected] <mailto:[email protected]>>
> *Subject: *Re: [GROW] Working Group Call for
> draft-msri-grow-bmp-bgp-rib-stats (start 06/Dec/2023 end 06/Jan/2024)
>
> [External Email. Be cautious of content]
>
>
> Hi GROW,
>
> I've noticed this errata report under discussion:
> https://urldefense.com/v3/__https://mailarchive.ietf.org/arch/msg/grow/g1d3cJhNMuSnchQiqX0lkQCnQkk/__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAov7CA-Pm$<https://urldefense.com/v3/__https:/mailarchive.ietf.org/arch/msg/grow/g1d3cJhNMuSnchQiqX0lkQCnQkk/__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAov7CA-Pm$>
>  
> <https://urldefense.com/v3/__https:/mailarchive.ietf.org/arch/msg/grow/g1d3cJhNMuSnchQiqX0lkQCnQkk/__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAov7CA-Pm$>
> If GROW agrees that "the L flag is only applied to Route Monitoring
> messages", to distinguish between pre-policy statistics and post-policy
> statistics of the Adj-RIBs-In, I think the following types could be
> added for RIB-IN Statistics:
>
> *  Type = TBD8: (64-bit Gauge) Number of routes in pre-policy Adj-RIBs-In.
> *  Type = TBD9: (64-bit Gauge) Number of routes in post-policy Adj-RIBs-In.
> *  Type = TBD10: Number of routes in per-AFI/SAFI pre-policy
> Adj-RIB-In.  The value is structured as: 2-byte Address Family
> Identifier (AFI), 1-byte Subsequent Address Family Identifier (SAFI),
> followed by a 64-bit Gauge.
> *  Type = TBD11: Number of routes in per-AFI/SAFI post-policy
> Adj-RIB-In.  The value is structured as: 2-byte Address Family
> Identifier (AFI), 1-byte Subsequent Address Family Identifier (SAFI),
> followed by a 64-bit Gauge.
>
> Waiting to hear your opinions, thanks.
>
> Best regards,
> Shunwan
>
>> -----Original Message-----
>> From: GROW [mailto:[email protected] <mailto:[email protected]>] On 
>> Behalf
> Of Zhuangshunwan
>> Sent: Saturday, December 9, 2023 3:15 PM
>> To: Job Snijders <[email protected]
> <mailto:[email protected]>>; [email protected]
> <mailto:[email protected]>
>> Subject: Re: [GROW] Working Group Call for
>> draft-msri-grow-bmp-bgp-rib-stats (start 06/Dec/2023 end 06/Jan/2024)
>>
>>
>> Hi Job, GROW,
>>
>> I have read the draft and support its adoption.
>>
>> Best regards,
>> Shunwan
>>
>> > -----Original Message-----
>> > From: GROW [mailto:[email protected] <mailto:[email protected]>] 
>> > On Behalf
> Of Job Snijders
>> > Sent: Wednesday, December 6, 2023 11:49 PM
>> > To: [email protected] <mailto:[email protected]>
>> > Subject: [GROW] Working Group Call for
>> > draft-msri-grow-bmp-bgp-rib-stats (start 06/Dec/2023 end 06/Jan/2024)
>> >
>> > Dear GROW,
>> >
>> > The author of draft-msri-grow-bmp-bgp-rib-stats asked whether the GROW
>> > working group could consider adoption of their internet-draft.
>> >
>> > This message is a request to the group for feedback on whether this
>> > internet-draft should be adopted.
>> >
>> > Title: Definition For New BMP Statistics Type
>> > Abstract:
>> >   RFC 7854 defined different BMP statistics messages types to observe
>> >   interesting events that occur on the router.  This document updates
>> >   RFC 7854 by adding new statistics type.
>> >
>> > The Internet-Draft can be found here:
>> > https://urldefense.com/v3/__https://www.ietf.org/archive/id/draft-msri-grow-bmp-bgp-rib-stats-00.h__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAohLYbTUy$<https://urldefense.com/v3/__https:/www.ietf.org/archive/id/draft-msri-grow-bmp-bgp-rib-stats-00.h__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAohLYbTUy$>
>> >  
>> > <https://urldefense.com/v3/__https:/www.ietf.org/archive/id/draft-msri-grow-bmp-bgp-rib-stats-00.h__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAohLYbTUy$>
>> > tml
>> >
>> > *** NOTE *** This draft has nothing other than BMP code point requests
>> > for counters. If adoption fails, the authors can go off an request FCFS
>> instead.
>> >
>> > Please share with the mailing list if you would like this work to be
>> > adopted by GROW, are willing to review and/or otherwise contribute to
>> this draft!
>> >
>> > WG Adoption call ends January 6th, 2024.
>> >
>> > Kind regards,
>> >
>> > Job / Chris
>> > GROW co-chairs
>> >
>> > _______________________________________________
>> > GROW mailing list
>> > [email protected] <mailto:[email protected]>
>> > https://urldefense.com/v3/__https://www.ietf.org/mailman/listinfo/grow__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAolGoROJy$<https://urldefense.com/v3/__https:/www.ietf.org/mailman/listinfo/grow__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAolGoROJy$>
>> >  
>> > <https://urldefense.com/v3/__https:/www.ietf.org/mailman/listinfo/grow__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAolGoROJy$>
>>
>> _______________________________________________
>> GROW mailing list
>> [email protected] <mailto:[email protected]>
>> https://urldefense.com/v3/__https://www.ietf.org/mailman/listinfo/grow__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAolGoROJy$<https://urldefense.com/v3/__https:/www.ietf.org/mailman/listinfo/grow__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAolGoROJy$>
>>  
>> <https://urldefense.com/v3/__https:/www.ietf.org/mailman/listinfo/grow__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAolGoROJy$>
>
> _______________________________________________
> GROW mailing list
> [email protected] <mailto:[email protected]>
> https://urldefense.com/v3/__https://www.ietf.org/mailman/listinfo/grow__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAolGoROJy$<https://urldefense.com/v3/__https:/www.ietf.org/mailman/listinfo/grow__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAolGoROJy$>
>  
> <https://urldefense.com/v3/__https:/www.ietf.org/mailman/listinfo/grow__;!!NEt6yMaO-gk!GcBz8ozUcDW3DcFms2m15hiJUwCN7bBXSR3wS_UdvGYS603ApxdNMc2XqFW9jpNp1XgyHbKnvQqlauvtUtmAolGoROJy$>
>
>
> _______________________________________________
> GROW mailing list
> [email protected]
> https://urldefense.com/v3/__https://www.ietf.org/mailman/listinfo/grow__;!!NEt6yMaO-gk!BgWI055OLz5BkhuhpOdOlZSgAgm1tWKlhAMrUM1xQnUqysGknt40nLSy2b368miqAB-2g51FFA$<https://urldefense.com/v3/__https:/www.ietf.org/mailman/listinfo/grow__;!!NEt6yMaO-gk!BgWI055OLz5BkhuhpOdOlZSgAgm1tWKlhAMrUM1xQnUqysGknt40nLSy2b368miqAB-2g51FFA$>
_______________________________________________
GROW mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/grow

Reply via email to