Bill Pringlemeir wrote:
> Bill Pringlemeir wrote:
> >> btw,  Is "is_action_url_spam()" in search.c ready to be removed?
 
> On 16 Jun 2007, [EMAIL PROTECTED] wrote:
> > No, why would you want to remove it?
 
>    * This checks XML data appended to search results for action URL spam. It's
>    * a weak heuristic but it should be sufficient for now. Gnoozle and others
>    * exploit a feature of LimeWire and sends results for faked, non-existent
> X  * files with bogus SHA-1s. This has been fixed in LimeWire, so there's no
> X  * need to invest too much into it and it can probably be removed in a 
> couple
> X  * of months from now (2006-12-20).

The comment isn't wrong but it says "probably" and "couple of months". It took
LimeWire about 2 years to fix it. Let's wait another two years. As long as
this function does not show up in profiling stats, there's not much of reason
to remove it anyway.

-- 
Christian

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Gtk-gnutella-devel mailing list
Gtk-gnutella-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel

Reply via email to