Hi Axel, Axel Simon <axel.si...@ens.fr> writes:
> Hi Andy, > > thank you very much for this patch. I'll push it as-is, but maybe you could > fix some minor details: > > - in TextTag there are some properties that set Pixbufs. These can be NULL. > Could you turn those > into Maybe Pixbuf (that's easy, just use the function > attributeFromMaybeObject). > - don't export the constructor of TextAttributes nor makeTextAttributes and > add some documentation > to this data type. > - could you convert the onFoo signals to foo in TextView and TextBuffer? > There's no point to create > new signals that are called onFoo since these are deprecated and might be > removed once all signals > are changed. You could also enclose all onFoo signals with #ifdef DEPRECATED > conditionals. See, > e.g. Widget.chs Okay, i will change those. > > There might be more, but I didn't get a chance to look at everything. Nor do > I have time this WE to > bind the TabArray in Pango. I will binding those when i have more time. :) > > If you want to do something that benefits the whole library, you could add > the foo signals for each > onFoo signal throughout. I've done the first few modules, starting from the > top of the Gtk2Hs > haddock documentation, but most remains to be done. Now, i use gtk2hs develop my project, i will check newest Gtk+/GNOME library before i use some module, i will try to complete module if i find something missing. > > Thanks a lot for your effort! Thank you too, you're hard work on gtk2hs so many years. I just do some little contribution. I will release new patch soon.... Cheers, -- Andy > > Axel. > > On Oct 1, 2009, at 9:42, Andy Stewart wrote: > >> Hi Axel, >> >> Today, i udpate all modules under Graphics.UI.Gtk.Multiline to Gtk+ >> 2.16. >> >> Below are changes log: >> >> ------------------------------> Changes log start >> <------------------------------ >> *** DONE Multiline.TextBuffer.chs.pp >> Change functions >> textBufferGetBounds >> Add functions: >> textBufferAddMark >> textBufferAddSelectionClipboard >> textBufferRemoveSelectionClipboard >> add signal : >> insert_child_anchor paste-done >> Fix doc: >> about variadic functions >> >> *** DONE Multiline.TextIter.chs.pp >> Add functions: >> textIterGetChildAnchor >> textIterGetAttributes >> textIterGetLanguage >> textIterForwardVisibleWordEnds >> textIterBackwardVisibleWordStarts >> textIterForwardVisibleWordEnd >> textIterBackwardVisibleWordStart >> textIterForwardVisibleCursorPosition >> textIterBackwardVisibleCursorPosition >> textIterForwardVisibleCursorPositions >> textIterBackwardVisibleCursorPositions >> textIterInRange >> textIterOrder >> >> *** DONE Multiline.TextMark.chs >> Add functions: >> textMarkNew >> >> *** DONE Multiline.TextTag.chs.pp >> Add functions: >> textAttributesCopy >> textAttributesCopyValues >> Add properties: >> accumulative-margin >> background-full-height-set >> background-gdk >> background-set >> background-stipple-set >> editable-set >> font-desc >> family-set >> foreground-gdk >> foreground-set >> foreground >> indent-set >> invisible-set >> justification-set >> language-set >> left-margin-set >> paragraph-background-gdk >> paragraph-background-set >> pixels-above-lines-set >> pixels-below-lines-set >> pixels-inside-wrap-set >> right-margin-set >> rise-set >> scale-set >> stretch-set >> strikethrough-set >> style-set >> underline-set >> variant-set >> weight-set >> wrap-mode-set >> Except properites: >> tabs >> >> *** DONE Multiline.TextView.chs.pp >> Add properties: >> im-module >> Add signals: >> onBackspace, >> afterBackspace, >> onMoveViewport >> afterMoveViewport >> onToggleCursorVisible >> afterToggleCursorVisible >> Except functions: >> textViewSetTabs >> textViewGetTabs >> Except properties: >> textViewTabs >> >> *** DONE General.Enums.chs.pp >> Add enum: >> ScrollStep (for singal `move-viewport` in TextView.chs.pp) >> >> ------------------------------> Changes log end >> <------------------------------ >> >> Almost all functions and types have update to 2.16, >> exception below fucntions: >> textViewSetTabs, textViewGetTabs >> and below properties: >> textTagTabs, textViewTabs. >> >> Above missing functions need binding PangoTab and PangoTabArray first >> (in `pango-tabs.c`) >> >> Axel, can you binding `pango-tabs.c` >> (http://library.gnome.org/devel/pango/1.24/pango-Tab-Stops.html) ? >> >> After then i will update those missing functions and types. >> >> Below is patch file: >> >> <Multiline.txt.zip> >> Please tell me if you found any problem in my code. >> >> I hope we can make all modules in gtk2hs udpate to newest version in >> someday.... >> >> Cheers, >> >> -- Andy >> >> ---------------------------------------------------------------------- >> -------- >> Come build with us! The BlackBerry® Developer Conference in SF, CA >> is the only developer event you need to attend this year. Jumpstart your >> developing skills, take BlackBerry mobile applications to market and stay >> ahead of the curve. Join us from November 9-12, 2009. Register now! >> http://p.sf.net/sfu/ >> devconf_______________________________________________ >> Gtk2hs-devel mailing list >> Gtk2hs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/gtk2hs-devel ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Gtk2hs-devel mailing list Gtk2hs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gtk2hs-devel
