Hi Axel, Axel Simon <axel.si...@ens.fr> writes: > Hi Andy, > > thank you very much for this patch. I'll push it as-is, but maybe you could > fix some minor details: > > - in TextTag there are some properties that set Pixbufs. These can be NULL. > Could you turn those > into Maybe Pixbuf (that's easy, just use the function > attributeFromMaybeObject). Sorry, i can't found any properties or functions handle Pixbufs.
> - don't export the constructor of TextAttributes nor makeTextAttributes and > add some documentation > to this data type. I have finish documentation of `makeNewTextAttributes`, and i don't know why not export `textAttributesNew` ? > - could you convert the onFoo signals to foo in TextView and TextBuffer? > There's no point to create > new signals that are called onFoo since these are deprecated and might be > removed once all signals > are changed. You could also enclose all onFoo signals with #ifdef DEPRECATED > conditionals. See, > e.g. Widget.chs I have finish it. Thanks, -- Andy ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Gtk2hs-devel mailing list Gtk2hs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gtk2hs-devel
