Sean Coates wrote: >> 3455 > > Does not need to be merged. > I don't think it should have been made public in the first place. The > real solution is to refactor toString, but obviously not everyone > thinks this.
Someone else will need to speak to this. I'm not sure what the object of this code is. Will this prevent toString from being refactored? Is this a suitable temporary solution to the problem in lieu of refactored toString code? Can you provide the toString code instead? >> 3479 > > Is a feature addition. Doesn't belong in 0.6.1, IMO (I could be wrong; > if so, please point me at the "what can go in point releases" document). This is a kind of feature addition, but I think it is a satisfactory solution for what is clearly a bug, whereas any other solution would be new and likely not as complete as this solution which we already have. I think including this is fair, please do disagree if you feel otherwise. > > Also, everyone: I think we should strive to avoid making whitespace > changes in the same commits as real changes. 3461 is a good example of > this. I know my IDE does this without notice unless that setting is turned off. If everyone would take a minute and check for this setting in their own editor, that could reduce some of these weird line-ending commits. Thanks! Owen --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
