On Sat, Apr 18, 2009 at 3:01 PM, Sean Coates <[email protected]> wrote:
> > > 3455 > > Does not need to be merged. > I don't think it should have been made public in the first place. The > real solution is to refactor toString, but obviously not everyone > thinks this. > > > 3479 > > Is a feature addition. Doesn't belong in 0.6.1, IMO (I could be wrong; > if so, please point me at the "what can go in point releases" document). It apparently fixed a bug (#943) preventing two rewrite rules with the same regex from working, and therefore matches my criteria for a bugfix release. It's not as if all hell breaks loose if we include it, so I don't see a problem with including it. When in doubt, include fixes earlier rather than later. > > > The rest look good. > > Also, everyone: I think we should strive to avoid making whitespace > changes in the same commits as real changes. 3461 is a good example of > this. Other people have complained about this in the past. As Owen says later, it's an editor setting. I use 3 or 4 different apps to edit things, depending on what machine I'm on and how in-depth the change is. Whitespace is the last of my concerns... Skim over it, it's not worth making a huge deal out of - focus on something important instead. --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
