Sean Coates wrote: >>>> 3455 ... > > Meller and I disagreed on this. I prefer to keep it protected. He > wanted it public so we didn't have to reroll the loop toString. If we > open it public now, then we will have unnecessary API changes down the > road if we move it back to protected. (I'm sure he thinks that we > should just always leave it public, but I think APIs should be minimal.)
Looking at it briefly, if one assumes that it is a reasonable expectation to be able to set the $escape value after the object is created, then you have either the choice of making $escape public or providing an accessor. Writing an accessor now would be trivial. Can we do that, or is your objection more that there should be no expectation to change the value of $escape? > In any case, it doesn't actually fix a release bug. IMO, it shouldn't > go into 0.6.x. Nor should the debate hold up 0.6.1. I agree - I don't know what release bug this fixes. >>>> 3479 ... > > That's a fair point. I don't want to get into a situation where we're > squeezing in last-minute features, but if it solves a clear bug, then > I have no objection. > That said, a couple of eyes on what it's doing and resulting commentary would be personally appreciated. Owen --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
