On 20.04.2009 18:28, Chris Meller wrote: > Re 3461: previously RemoteRequest had always set that, not just for > non-POST commands... and no one ever seemed to have a problem. Can you > explain an instance in which converting all newlines to \r\n would be an > issue?
Documentation seems contradictory and I don't have time to dig into cURL's source now. Either CURLOPT_CRLF only has an effect on FTP uploads, in which case setting it makes no sense; or it has an effect on all uploads, in which case we potentially mangle data we know nothing about (e.g. whether it's text); or it only applies when CURL_TRANSFERTEXT is also set, in which case it does nothing for us anyway; or it only applies for transmissions with a text mimetype, in which case we mangle received data we know little about without asking the application layer. To me that looks like a bunch of reasons not to use the _CRLF option and no reason to. Please not we're not mangling data in the SocketRequestProcessor either. If we want to expose such a feature, the RR API should be extended to account for 'text' transmissions, and all RequestProcessors should be extended to do the conversions neccessary. But, honestly, I don't see the point. -Matt --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
