[
https://issues.apache.org/jira/browse/HADOOP-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515446
]
Tsz Wo (Nicholas), SZE commented on HADOOP-1298:
------------------------------------------------
- This patch is much nicer. I like the ideas of making FSDirectory.INode
static and using StringBuffer. It helps reducing memory usages.
- For the last point (introducing EMPTY_BLOCKS_ARRAY, EMPTY_CHILDREN_MAP), it
is a programming style issue and the change is quite involved. In general, I
think we should respect the previous author's decision unless we can fix bugs
or make actual improvement.
- BTW, all the changes in this patch is not related to this issue. I think we
should probably create a new Jira issue for it. It won't be right if we create
issue A but work on issue B.
> adding user info to file
> ------------------------
>
> Key: HADOOP-1298
> URL: https://issues.apache.org/jira/browse/HADOOP-1298
> Project: Hadoop
> Issue Type: New Feature
> Components: dfs, fs
> Reporter: Kurtis Heimerl
> Fix For: 0.15.0
>
> Attachments: fsdirectory-cleanup-20070725-1351.patch,
> hadoop-dev-20070720-1633.patch.gz, hadoop-dev-20070724-0020.patch.gz,
> hadoop-dev-20070724-2349.patch.gz, hadoop-user-munncha.patch,
> hadoop-user-munncha.patch, hadoop-user-munncha.patch,
> hadoop-user-munncha.patch10, hadoop-user-munncha.patch11,
> hadoop-user-munncha.patch12, hadoop-user-munncha.patch13,
> hadoop-user-munncha.patch14, hadoop-user-munncha.patch15,
> hadoop-user-munncha.patch16, hadoop-user-munncha.patch17,
> hadoop-user-munncha.patch4, hadoop-user-munncha.patch5,
> hadoop-user-munncha.patch6, hadoop-user-munncha.patch7,
> hadoop-user-munncha.patch8, hadoop-user-munncha.patch9,
> hdfs-access-control.patch.gz
>
>
> I'm working on adding a permissions model to hadoop's DFS. The first step is
> this change, which associates user info with files. Following this I'll
> assoicate permissions info, then block methods based on that user info, then
> authorization of the user info.
> So, right now i've implemented adding user info to files. I'm looking for
> feedback before I clean this up and make it offical.
> I wasn't sure what release, i'm working off trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
