[ 
https://issues.apache.org/jira/browse/HAMA-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115699#comment-13115699
 ] 

Vinod Kumar Vavilapalli commented on HAMA-439:
----------------------------------------------

bq. If we move BSP/BSPInterface to API module, there is no BSPPeer class which 
is needed for the parameter. But we have an interface for it called 
BSPPeerInterface.
I ran into the same thing, yes that is the correct way.

bq. The shellscript is a great idea. But as you can see in my last post, we 
need to decouple a few things before we can move them.
Yes I recognized that. Didn't know you were on your way to generating patch 
too, so thought of unblocking you ;)

Anyways, glanced through your patch. You are a bit ahead, great! I think you 
should drop the moving of files from the patch and fix everything else 
including creating interfaces and impls like BSPPeerImpl and other related code 
changes. That way it'll be easier to review.
                
> Reorganize modules for YARN/MR-NextGen integration
> --------------------------------------------------
>
>                 Key: HAMA-439
>                 URL: https://issues.apache.org/jira/browse/HAMA-439
>             Project: Hama
>          Issue Type: Sub-task
>    Affects Versions: 0.3.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Thomas Jungblut
>             Fix For: 0.4.0
>
>         Attachments: HAMA-349-20110927.txt, HAMA-349-move-20110927.sh, 
> HAMA-439.patch
>
>
> I'd like to get started on HamaV2 to work with YARN/MR-nextgen.
> Here's what I think should be the module structure:
>  - *api*: Code from HamaV1 related to APIs that will be moved to this new 
> module. This will mainly have the BSP APIs: _BSP_, _BSPPeerInterface_ and all 
> the related records like _BSPMessage_, _BSPMessageBundle etc.
>  - *core*: Current/HamaV1 server code. Will have the current 
> _BSPMaster_/_GroomServer_ infrastructure. We should probably rename it to 
> {{classic-server}} or something similar.
>  - *server*: New Hama server implementation to work with YARN. Will have 
> _BSPApplicationMaster_, _BSPTask_ and related code.
>  - *client*: Code from HamaV1 related to client that will be moved to this 
> new module. This will mainly have the client-submission classes/interfaces 
> like _BSPJob_, _BSPJobClient_, _JobStatus_ etc. It will be configurable to 
> either run with the classic-server implementation or with YARN.
> There will not be any package changes but only code-moves across modules, so 
> we will be backwards compatible.
> How does it look? Any thoughts/suggestions?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to