I would suggest that it will not harm even if you relax the check for client hello too as the old client can using SSL 3.0 is still supported and its according to RFC and also note that the max supported TLS version is 3.3. I would suggest the below mentioned changes.
288c288 < /* Check for TLSv1 or later (SSL version >= 3.1) */ --- > /* Check for SSLv3 or later (SSL version >= 3.0) */ 291c291 < if (data[1] < 0x03 || data[2] < 0x01) --- > if (data[1] < 0x03 || data[2] > 0x03) 322c322 < if (data[0] < 0x03 || data[1] < 0x01) /* TLSv1 minimum */ --- > if (data[0] < 0x03 || data[1] > 0x03) /* SSLv3 minimum TLSv1.2 maximum */ On Fri, Apr 11, 2014 at 12:43 AM, Lukas Tribus <[email protected]> wrote: > Hi, > > > > Basically we just need to relax the record layer check to SSLv3 - and > > leave the clienthello check as is, right? > > > > Does the attached diff do the job for you correctly, Pravin? > > I have reproduced the issue with gnutls and can confirm that the patch > fixes the problem. > > The function now requires only SSLv3 or later in the record layer, but > still requires at least TLSv1.0 in the client hello. > > I don't think any SNI capable client announces SSLv2 in the record layer > or worse. > > > I will submit the patch formally. > > > > Regards, > > Lukas > >
