Hi James,
On Mon, Jul 07, 2014 at 03:43:38PM -0400, James Westby wrote:
> Indicate for each statistic which types may have a value for
> that statistic.
>
> Explain some of the provided statistics a little more deeply.
That's really kind, but I have some comments below :
> The statistics may be consulted either from the unix socket or from the HTTP
> -page. Both means provide a CSV format whose fields follow.
> +page. Both means provide a CSV format whose fields follow. In brackets after
> +each field are the types for which the field may take a value. Types not
> +in that list will always have a blank value for that field.
>
> - 0. pxname: proxy name
> + 0. pname: proxy name [FRONTEND, BACKEND, SERVER]
^^^^^
here you mangled the field name, it's "pxname"
> 1. svname: service name (FRONTEND for frontend, BACKEND for backend, any
> name
(...)
> + for server) [FRONTEND, BACKEND, SERVER]
> + 2. qcur: current queued requests. For the backend this reports the number
> queued without a server assigned. [BACKEND, SERVER]
(...)
Please respect the 80-char limit on the doc, that's really important for
people reading in directly on servers. And as a person whom it happens from
time to time and even over a serial port sometimes, I can tell you how much
a pain it is to see lines wrapping. There are quite a number hyper-long lines
starting at point 13!
However I really appreciate the amount of details you've put there and am
really willing to get this merged. I have not verified if there's any other
mangled field name, please double-check, it can avoid some implementers'
headache!
Thanks!
Willy
