Hi Remi!


> Well, I really hope you're right. This patch looks in the cipher's
> description instead of its name. Sorry about the mess.


in src/ssl_sock.c:1582:11:
>   ciphers = ctx->cipher_list;

can we use the API instead of accessing cipher_list directly?
With [1] perhaps?


Background: I'm playing with the new OpenSSL forks BoringSSL and
LibreSSL (with some #ifdef'ing), and when compiling with BoringSSL
I see:
src/ssl_sock.c: In function 'ssl_sock_prepare_ctx':
src/ssl_sock.c:1582:11: warning: assignment from incompatible pointer \
 type [enabled by default]
   ciphers = ctx->cipher_list;


One of the (new) OpenSSL roadmap goals [2] is to deprecated those
supposed-to-be-private APIs, so this may not be a bad idea
anyway?



Lukas


[1] https://www.openssl.org/docs/ssl/SSL_get_ciphers.html
[2] https://www.openssl.org/about/roadmap.html

                                          

Reply via email to