Re: cppcheck finding

[Willy Tarreau]

Hello Ilya,

On Thu, Sep 14, 2017 at 11:11:36PM +0500, ???? ??????? wrote:
> hello,
> 
> [src/flt_http_comp.c:926] -> [src/flt_http_comp.c:926]: (warning) Either
> the condition 'txn' is redundant or there is possible null pointer
> dereference: txn.
> 
> should there be && instead of || ?

You're speaking about this :

        if (!(txn || !(txn->rsp.flags & HTTP_MSGF_COMPRESSING)))
                return 0;

and you're right, it should be this :

        if (!txn || !(txn->rsp.flags & HTTP_MSGF_COMPRESSING))
                return 0;

CCing Christopher. We've had this since 1.7 apparently.

Thanks for the report!
Willy