great, thank for the feedback. there're few things like that
[src/flt_http_comp.c:926] -> [src/flt_http_comp.c:926]: (warning) Either the condition 'txn' is redundant or there is possible null pointer dereference: txn. [src/flt_spoe.c:2765] -> [src/flt_spoe.c:2766]: (warning) Either the condition 'ctx==NULL' is redundant or there is possible null pointer dereference: ctx. [src/haproxy.c:568]: (error) Common realloc mistake: 'next_argv' nulled but not freed upon failure [src/server.c:3993] -> [src/server.c:3995]: (warning) Either the condition 'nameserver' is redundant or there is possible null pointer dereference: nameserver. [src/ssl_sock.c:4403] -> [src/ssl_sock.c:4397]: (warning) Either the condition '!bind_conf' is redundant or there is possible null pointer dereference: bind_conf. I had a quick look to them, seem to be logical errors. are there any CI process for haproxy ? I didn't find any 2017-09-15 11:26 GMT+05:00 Willy Tarreau <[email protected]>: > Hello Ilya, > > On Thu, Sep 14, 2017 at 11:11:36PM +0500, ???? ??????? wrote: > > hello, > > > > [src/flt_http_comp.c:926] -> [src/flt_http_comp.c:926]: (warning) Either > > the condition 'txn' is redundant or there is possible null pointer > > dereference: txn. > > > > should there be && instead of || ? > > You're speaking about this : > > if (!(txn || !(txn->rsp.flags & HTTP_MSGF_COMPRESSING))) > return 0; > > and you're right, it should be this : > > if (!txn || !(txn->rsp.flags & HTTP_MSGF_COMPRESSING)) > return 0; > > CCing Christopher. We've had this since 1.7 apparently. > > Thanks for the report! > Willy >
