On Mon, Nov 20, 2017 at 03:58:34PM +0100, Tim Düsterhus wrote: > Coming along is a patch that implements your suggested changes. > > Two things: > - I was unsure whether to renumber the GTUNE_* constants. I opted not to.
Not needed. It might be a cleanup for later. However I moved your decalaration (1<<10) after (1<<9) to avoid the risk that someone else spots the empty slot and reuses it. > - I was unsure whether `#if defined(...)` or `#ifdef` is the variant to use > for the USE_SYSTEMD option. You use both and I was unable to find out > whether there is a scheme you follow. The two are valid. Most often ifdef is used, but when you want to apply combinations, if defined() often becomes more convenient. > Thanks for your patience and really helpful feedback so far :-) You're welcome, thanks for working on this. I've applied your patch with William's blessing :-) Willy
