Hi LuKas, On Fri, Jul 20, 2018 at 01:53:35PM +0200, Lukas Tribus wrote: > Hello Oliver, > > On Fri, 20 Jul 2018 at 11:55, Olivier Houchard <ohouch...@haproxy.com> > wrote: > > > > Hi, > > > > On Fri, Jul 20, 2018 at 12:22:20AM +0000, Thrawn wrote: > > > So...is there a way to adapt this patch so it won't cause random SSL > errors and is suitable to apply to the trunk? We don't really want to run a > customised build in production... > > > > You don't need the patch, just using USE_PTHREAD_PSHARED=yes should be > enough. > > I don't really understand, are you saying that the spinlock introduced > in cd1a526a doesn't work properly (as in: causes random SSL errors)? How > does this work on FreeBSD and OpenBSD? This sounds like a supported > configuration on a supported OS causes random SSL errrors when in > multiprocess mode, but I imagine I got something wrong here. > > Please help me understand this issue. >
No, it works fine, but if you compile without USE_THREADS, the HA_ATOMIC* macroes I used in my patch are in fact not atomic at all, so that may cause random and unpredictable failures if the SSL cache code use them. Regards, Olivier
