Hi.

Am 05.03.2019 um 13:47 schrieb Willy Tarreau:
> Hi all,
> 
> back to this old thread :
> 
> On Mon, Jan 21, 2019 at 03:36:22PM +0100, Willy Tarreau wrote:
>> I don't know if wurfl builds at all by the way since the last update to
>> the module is its introduction more than 2 years ago.
> 
> So now at least I've got the response. This code doesn't build and was
> broken no less than 9 months ago without anyone ever noticing. And it
> never cared to try to be thread-compatible over the last 28 months.
> This is not a feature but a useless heavy weight we're carrying behind
> us for no valid reason. Given that it hasn't ever been maintained since
> its introduction and obviously doesn't even have a user, I've removed
> it. I'd be tempted to backport the cleanup patch to 1.9 since it doesn't
> build there either, but I don't like to remove features in stable
> branches. One could argue that 1) not building, 2) not working, and 3)
> not being maintained doesn't exactly qualify as "stable". So maybe in the
> end I'll do it there as well. And I'm sure it will not affect distros!
> But I'm open to opinions on the subject.

>From my point of view if even the contributor does not care that this feature
works well, why should we (the community) care?

The 51d have answered quite fast with a fix.

>From haproxy point of view I would add a dedicated note and a Warning that this
feature does not work in the current version. If anyone want to fix this step
forward and fix it.

I would remove it in 2.x.

Jm2c

> Regards,
> Willy

Regards
Aleks

Reply via email to