triggered by coverity; src_port is set earlier. this should fix github issue #467
Fixes: 7fec02153712 ("MEDIUM: proxy_protocol: Convert IPs to v6 when protocols are mixed") Signed-off-by: William Dauchy <w.dau...@criteo.com> --- src/connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/connection.c b/src/connection.c index ced919f0e..b3c39f1fb 100644 --- a/src/connection.c +++ b/src/connection.c @@ -1372,7 +1372,7 @@ int make_proxy_line_v2(char *buf, int buf_len, struct server *srv, struct connec if (dst->ss_family == AF_INET) { v4tov6(&tmp, &((struct sockaddr_in *)dst)->sin_addr); memcpy(hdr->addr.ip6.dst_addr, &tmp, 16); - hdr->addr.ip6.src_port = ((struct sockaddr_in *)src)->sin_port; + hdr->addr.ip6.dst_port = ((struct sockaddr_in *)src)->sin_port; } else { memcpy(hdr->addr.ip6.dst_addr, &((struct sockaddr_in6 *)dst)->sin6_addr, 16); -- 2.24.1