Thanks for your review Tim On Sun, Jan 26, 2020 at 7:20 PM Tim Düsterhus <t...@bastelstu.be> wrote: > > int i; > > Consider moving this into the `while` loop to reduce the scope of `i`.
I'm not against doing this when this is a block condition, but for a loop, I find it a bit dirty and confusing. > For consistency consider to to either: > *string and !*string > or > *string != '\0' and *string == '\0' > or > *string != 0 and *string == 0 fixed. Thanks, -- William