Hi Tim,

On Sun, Feb 16, 2020 at 01:03:31AM +0100, Tim Duesterhus wrote:
> `curr_idle_thr` is of type `unsigned int`, not `int`. Fix this issue by
> taking the size of the dereferenced `curr_idle_thr` array.
> 
> This issue was introduced when adding the `curr_idle_thr` struct member
> in commit f131481a0af79037bc6616edf450ae81d80084d7. This commit is first
> tagged in 2.0-dev1 and marked for backport to 1.9.

In fact it's not a bug since the storage type remains the same (int vs
unsigned int). However I hate seeing sizeof(type) being placed anywhere
instead of sizeof(*pointer) because these are hard to find the day the
type changes and can cause bugs later.

So I'd rather tag it as cleanup and not backport it since it will not
change the output code.

Thanks,
Willy

Reply via email to