Patrick, Am 07.05.20 um 18:54 schrieb Patrick Gansterer: >> I skipped the patch (that's why I did not ACK the first, but only the >> second one), because it was a very large change of code that was just >> moved. Nonetheless I should have noticed the missing body and noted that >> during my review. > > IMHO, that's a patch you usually do not want review.
Yes, that's why I did not. However the commit message is not directly part of the patch, so I should have. >> Please note that I review patches on a voluntary basis. I'm not an >> "employed first level reviewer". > > That's not what I meant. I thought that when regular participants on > this list do not spot the errors of first time contributes, it can't be > that obvious and directing to CONTRIBUTING might not be enough. I agree with you that Willy's reply was overly blunt in this case. Especially since you demonstrated an effort to take my review into a account and he noticed my Ack (implying it can't be too bad). >> Liking HAProxy and wanting to give something back is my motivation as >> well. I am very sorry to see how this experience went for you. If it is >> of any help to you: This is definitely not how it usually goes. > > Then here is my next try. ;-) > > I've rebased my changes to reflect the recent changes and added the > missing description to the first patch. I've now taken a look at both patches now and both are: Reviewed-by: Tim Duesterhus <[email protected]> Best regards Tim Düsterhus
