Emeric,
Am 02.06.20 um 11:29 schrieb Emeric Brun:
> In attachement a proposed patch for this issue.
>
Thanks. The changes to the doc look good to me.
Regarding peers.c:
> +/* network key types;
> + * network types were directly and mistakenly
> + * mapped on sample types, to keep backward
> + * compatiblitiy we keep those values but
> + * we now use a internal/network mapping
> + * to avoid further mistakes adding or
> + * modifying internals types
> + */
> +enum {
> + PEER_KT_ANY = 0, /* any type */
> + PEER_KT_RESV1, /* UNUSED */
> + PEER_KT_SINT, /* signed 64bits integer type */
> + PEER_KT_RESV2, /* UNUSED */
Maybe call this RESV3 to make it clear that the numeric value is '3'.
> + PEER_KT_IPV4, /* ipv4 type */
> + PEER_KT_IPV6, /* ipv6 type */
> + PEER_KT_STR, /* char string type */
> + PEER_KT_BIN, /* buffer type */
> + PEER_KT_TYPES /* number of types, must always be last */
> +};
-
> + * Note: Undeclared mapping maps entry to SMP_ST_ANY == 0
This should read SMP_T_ANY.
Also backporting instructions are missing from the commit message.
Other than that the patch looks good to me, but I didn't actually test a
binary compiled from it.
Best regards
Tim Düsterhus
