Maciej,

Am 20.11.20 um 15:58 schrieb Maciej Zdeb:
> I've implemented a http-request del-header with optional flag -m [beg, sub,
> str, end]. I'm not sure if my approach is correct so I'm not adding support
> for the "reg" method in these patches. I've doubts about (ab)using the
> action field in the act_rule struct for storing selected matching method.
> What if we'll need additional flags? :)
> 

In 0002:

+               default:
+                       memprintf(err, "-m with unsupported matching method 
'%s'",
args[cur_arg]);
+                       return ACT_RET_PRS_ERR;;
+               }

There's a duplicate semicolon there.

In 0003:

Merge the test into the previous commit, please. This ensures the test
is always there when the feature is there and absent if it is not.

Best regards
Tim Düsterhus

Reply via email to