Maciej, Am 20.11.20 um 20:13 schrieb Maciej Zdeb: > Thank you Tim for your help and support! :) > > I've fixed some coding-style issues. I hope that all trivial mistakes > (wrong bracing, indention etc) are now fixed. > > I have a question about: > free(px->conf.lfs_file); > px->conf.lfs_file = strdup(px->conf.args.file); > px->conf.lfs_line = px->conf.args.line; > > It is on various places in http_act.c and so I've also placed that in my > patch, however I'm not sure if it's really necessary. I just don't > understand this fragment, why it is there. :( >
I might be entirely wrong there, but my understanding that these are used for error reporting with the parsing of log-format strings and thus should not be in your code, because you don't use log-format strings. My understanding is that these are required if you support the %[...] syntax, as in: http-request set-header foo %[bar] With %[bar] being the log-format string. I suggest waiting for an authoritative answer before adjusting anything, though. This is just a guess based off the comments for the .lfs_file member of the conf struct. :-) Best regards Tim Düsterhus
