I've added to commit msg "This is related to GitHub issue #909" because there is still no support for reg matching in this patch.
pt., 20 lis 2020 o 17:54 Tim Düsterhus <[email protected]> napisał(a): > > +#REQUIRE_VERSION=2.2 > > This should either be 2.4 or be removed. The removal should be safe, > because it is integrated within a single commit. > Removed. > +# This config tests various http request rules (set/replace) > manipulating the > > +# path, with or without the query-string. It also test path and pathq > sample > > +# fetches. > > I believe this comment is not correct. > > > + http-response del-header x-str2 -m str > > + http-response del-header x-beg -m beg > > + http-response del-header end1 -m end > > Indentation is messed up there, because you mixed tabs and spaces. > True, I was so excited that my code started to work that I didn't notice this garbage. I'm very sorry for wasting your time. > + * Otherwsize ACT_RET_ERR is returned. > > There is a typo there. > Fixed. > + rule->action = PAT_MATCH_STR; // exact matching (-m str) > Changed to multiline. :) > I now also tested your patch. I noticed the following issues: > > > http-response del-header -m beg > > This should probably cause a configuration parsing failure, but is > silently accepted. I am not sure what is does, delete headers called > `-m`, ignoring the `beg`? > Yes, it deleted the `-m` header and ignored `beg`. I've added an additional check, if an unsupported flag is set. Thank you again Tim!
0001-BUG-MINOR-http_htx-Fix-searching-headers-by-substrin.patch
Description: Binary data
0002-MINOR-http_act-Add-m-flag-for-del-header-name-matchi.patch
Description: Binary data
