Marcin,

On 7/14/21 2:01 PM, Marcin Deranek wrote:
Thank you for all comments I have received regarding JA3 Fingerprinting
patches. Here is the new set of patches which incorporated all your
suggestions.

Sorry I gave a little outdated advice regarding the reg-tests. For any new tests please use:

  feature cmd "$HAPROXY_PROGRAM -cc 'version_atleast(2.5-dev0)'"

instead of

  #REQUIRE_VERSION=2.5

Other than that the tests LGTM from a glance. I didn't look at your C and I also didn't (yet) compare the tests against the documentation you have written.

Best regards
Tim Düsterhus

Reply via email to