Hello Willy, On Thu, Aug 26, 2021 at 8:40 PM Willy Tarreau <[email protected]> wrote:
> Hi Marcin, > > On Thu, Aug 26, 2021 at 06:56:20PM +0200, Marcin Deranek wrote: > > Hi Willy, > (...) > > No worries. Hopefully soon this will get merged. Attaching latest patches > > with all modification included. > > Thanks for detailing all the points. I trust that you did them as you > said, in the worst case it will just lead to bug fixes, that's fine. I > quickly glanced over all of it a last time and think it's OK, so I've > pushed it No fancy stuff just corrections as promised :-)) Thank you. I think I tested this fairly well, so I do not expect bugfixes.. but you never know :-) > I just wish I had pushed into a temporary branch first to see if the CI > complains on certain openssl versions, but fortunately it went fine :-) > Patches do not touch OpenSSL code, so if things worked before they should work after :-) BTW: You recall I "complained" about ssl_fc_cipherlist_xxh value being pre-calculated during TLS Client Hello message parsing which I found a bit "strange". One of the reasons could be that ssl_fc_cipherlist_str fallsback to that value (ssl_fc_cipherlist_xxh) when it cannot provide names due to OpenSSL limitations. > I changed the level of the last patch from MINOR to MEDIUM as it deprecates > a config setting and will result in emitting a new warning for some users, > thus it will have a visible impact. > I see. Thank you once again! Marcin Deranek
