Hi, Do you have any update on merging this?
Regards, Marcin Deranek On Thu, Jul 15, 2021 at 2:28 PM Marcin Deranek <[email protected]> wrote: > Hi Tim, > > Updated (see attachments). Other patches did not change. > Regards, > > Marcin Deranek > > On Thu, Jul 15, 2021 at 10:20 AM Tim Düsterhus <[email protected]> wrote: > >> Marcin, >> >> On 7/14/21 2:01 PM, Marcin Deranek wrote: >> > Thank you for all comments I have received regarding JA3 Fingerprinting >> > patches. Here is the new set of patches which incorporated all your >> > suggestions. >> >> Sorry I gave a little outdated advice regarding the reg-tests. For any >> new tests please use: >> >> feature cmd "$HAPROXY_PROGRAM -cc 'version_atleast(2.5-dev0)'" >> >> instead of >> >> #REQUIRE_VERSION=2.5 >> >> Other than that the tests LGTM from a glance. I didn't look at your C >> and I also didn't (yet) compare the tests against the documentation you >> have written. >> >> Best regards >> Tim Düsterhus >> > > > -- > Marcin Deranek > Senior Site Reliability Engineer > [image: Booking.com] <https://www.booking.com/> > Making it easier for everyone > to experience the world. >
