Yes, I pushed an equivalent patch, if not the exact same. On 14-01-03 04:41 AM, Ed Trager wrote: > Oh, wait, you did push Jonathan's patch, thanks so much! Sorry I missed that > first time around! > > > On Thu, Jan 2, 2014 at 3:38 PM, Ed Trager <[email protected] > <mailto:[email protected]>> wrote: > > Happy New Year, Behdad! > > Hey just wondering what do you think about Jonathan's patch (attached > below)? > > Best - Ed > > > ---------- Forwarded message ---------- > From: *Jonathan Kew* <[email protected] > <mailto:[email protected]>> > Date: Fri, Dec 27, 2013 at 12:09 PM > Subject: Re: [HarfBuzz] Change in HarfBuzz after version 0.90 ? > To: Ed Trager <[email protected] <mailto:[email protected]>>, Danh > Hong <[email protected] <mailto:[email protected]>>, Behdad Esfahbod > <[email protected] <mailto:[email protected]>> > Cc: Martin Hosken <[email protected] <mailto:[email protected]>>, Richard > Wordingham <[email protected] > <mailto:[email protected]>>, Theppitak Karoonboonyanan > <[email protected] <mailto:[email protected]>>, Harfbuzz > <[email protected] <mailto:[email protected]>> > > > On 27/12/13 16:21, Ed Trager wrote: > > > Hi, Martin, Richard, and Danh Hong, > > With regard to forcing the re-ordering of the > UCD-enforced-but-totally-__broken normalisation of TAI THAM TONE MARK > plus > U+1A60, does the following approach in the OpenType feature file make > sense as the quickest and cleanest way to do it or not?: > > Basically the idea is to compose the out-of-order pair of characters > into a ligature; and then take that ligature and decompose it back to > a > pair of characters that are in the correct order: > > If there is a better way to do this in OpenType, please enlighten me! > :-) I was trying to get this to work last night, so far without > success: > > > The trouble with this idea (or at least one trouble with it!) is that by > the time your lookups have a chance to do anything, harfbuzz has already > inserted dotted-circle glyphs because it treated the (normalized) sequence > as being a "broken" cluster. The pattern for a "consonant syllable" in the > SEAsian shaper allows for a <sakot, consonant> pair (i.e. a subjoined > consonant) among the various possible syllable-tail items, but it does not > allow for the <sakot> and <cons> to be separated by other marks, which is > what the normalization does. > > You -might- be able to work around this by explicitly including the dotted > circles in your ligature-composition rules, though that will make them all > more cumbersome. The better way forward is for us to fix harfbuzz, as > previously suggested. > > Possible patch attached; Behdad, wdyt? > > > > > > > _______________________________________________ > HarfBuzz mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/harfbuzz >
-- behdad http://behdad.org/ _______________________________________________ HarfBuzz mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/harfbuzz
