The glue code is small (~ 30 lines), easy to reason about, and unlikely
to change so I think writing tests would be overkill. Any effort spent
writing tests would be better spent just getting a fresh pair of eyes to
look at the code and reason about it. If you really want to contribute
tests I won't say no and I will merge any pull requests for tests, but I
don't consider tests to be a blocking feature.
As far as resource management goes, I'm specifically avoiding
`pipes-safe` at the moment and sticking to the `withXXX` idiom.
`pipes-safe` is the only API in the `pipes` ecosystem that I don't have
absolute faith in, so I don't want to propagate it further until I play
around with other resource management ideas that can finalize things
more promptly and automatically.
On 01/29/2014 08:30 PM, Danny Navarro wrote:
The `http-client-conduit` API is intended to be used mostly through
`http-conduit`, which is also quite thin [1]. `http-conduit` includes
an extensive battery of tests [2]. We could start porting the main
ones and implement whatever is needed ala TDD. Is there something in
the tests for which we'd like a different API `pipes-http`? What about
managing resources?
[1]
http://hackage.haskell.org/package/http-conduit-2.0.0.4/docs/src/Network-HTTP-Conduit.html
[2]
https://github.com/snoyberg/http-client/blob/master/http-conduit/test/main.hs
On Wed, Jan 29, 2014 at 3:07 AM, Gabriel Gonzalez <[email protected]> wrote:
Alright, I set up a draft of what I had in mind. This is the minimal
possible wrapper around `http-client`:
https://github.com/Gabriel439/Haskell-Pipes-HTTP-Library
It doesn't depend on any of the latest parsing features since it offloads
the parsing work to `http-client` so it can be released at any time.
--
You received this message because you are subscribed to the Google Groups
"Haskell Pipes" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
--
You received this message because you are subscribed to the Google Groups "Haskell
Pipes" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
