[ 
https://issues.apache.org/jira/browse/HCATALOG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104290#comment-13104290
 ] 

[email protected] commented on HCATALOG-60:
-------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1861/
-----------------------------------------------------------

Review request for hcatalog and Sushanth Sowmyan.


Summary
-------

review of HCatalog-60, refactor HCatalog output stuff to support non file-based 
storage drivers


This addresses bug HCatalog-60.
    https://issues.apache.org/jira/browse/HCatalog-60


Diffs
-----

  src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitter.java 
PRE-CREATION 
  src/java/org/apache/hcatalog/mapreduce/DefaultOutputFormat.java PRE-CREATION 
  src/java/org/apache/hcatalog/mapreduce/DefaultRecordWriter.java PRE-CREATION 
  src/java/org/apache/hcatalog/mapreduce/FileOutputCommitter.java PRE-CREATION 
  src/java/org/apache/hcatalog/mapreduce/FileOutputFormat.java PRE-CREATION 
  src/java/org/apache/hcatalog/mapreduce/FileOutputStorageDriver.java 
PRE-CREATION 
  src/java/org/apache/hcatalog/mapreduce/FileRecordWriter.java PRE-CREATION 
  src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputCommitter.java 8516e1a 
  src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java d289714 
  src/java/org/apache/hcatalog/mapreduce/HCatEximOutputCommitter.java 4e5c4d1 
  src/java/org/apache/hcatalog/mapreduce/HCatEximOutputFormat.java 47ddae3 
  src/java/org/apache/hcatalog/mapreduce/HCatOutputCommitter.java 973a4b6 
  src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java 7a99caa 
  src/java/org/apache/hcatalog/mapreduce/HCatOutputStorageDriver.java 8ef0d25 
  src/java/org/apache/hcatalog/mapreduce/HCatRecordWriter.java e71b9af 
  src/java/org/apache/hcatalog/mapreduce/OutputCommitterContainer.java 
PRE-CREATION 
  src/java/org/apache/hcatalog/mapreduce/OutputFormatContainer.java 
PRE-CREATION 
  src/java/org/apache/hcatalog/mapreduce/RecordWriterBaseContainer.java 
PRE-CREATION 
  src/java/org/apache/hcatalog/pig/HCatEximStorer.java 3f1db06 
  src/java/org/apache/hcatalog/pig/HCatStorer.java 90d14c0 
  src/java/org/apache/hcatalog/rcfile/RCFileOutputDriver.java 6efc4d9 
  src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java 2dee111 
  src/test/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java 
dfc7a53 
  src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java 506ed4e 
  src/test/org/apache/hcatalog/rcfile/TestRCFileOutputStorageDriver.java 
4c4acfe 

Diff: https://reviews.apache.org/r/1861/diff


Testing
-------

all unit tests passed


Thanks,

Francis



> Refactor HCatalog to support non-filebased outputformats
> --------------------------------------------------------
>
>                 Key: HCATALOG-60
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-60
>             Project: HCatalog
>          Issue Type: Bug
>    Affects Versions: 0.3
>            Reporter: Francis Liu
>            Assignee: Francis Liu
>              Labels: hbase, refactoring
>         Attachments: HCatalog-60.patch, HCatalog-60_rev2.patch
>
>
> Some table sources have no need for paths (ie HBase) and thus 
> JobInfo.location may be null. Looks like commitJob was trying to do a test 
> before acting on the location but buggy. abortJob does not have such check.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to