[
https://issues.apache.org/jira/browse/HCATALOG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108997#comment-13108997
]
Sushanth Sowmyan commented on HCATALOG-60:
------------------------------------------
Hi Francis,
For most part, the patch looks okay, I've not been rigourous enough..
The only comment I had regarding your patch is that I see that you use
HCatRecord as your Value type for specification of underlying
OutputFormatContainer , and that is probably problematic, and should have just
been Writable - still need to check my instinct on this though.
Yes, it's probably better if we do meet and go through this in person, although
we do want to capture the results of that on the jira.
> Refactor HCatalog to support non-filebased outputformats
> --------------------------------------------------------
>
> Key: HCATALOG-60
> URL: https://issues.apache.org/jira/browse/HCATALOG-60
> Project: HCatalog
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Francis Liu
> Assignee: Francis Liu
> Labels: hbase, refactoring
> Attachments: HCatalog-60.patch, HCatalog-60_rev2.patch
>
>
> Some table sources have no need for paths (ie HBase) and thus
> JobInfo.location may be null. Looks like commitJob was trying to do a test
> before acting on the location but buggy. abortJob does not have such check.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
