[
https://issues.apache.org/jira/browse/HCATALOG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117410#comment-13117410
]
Alan Gates commented on HCATALOG-60:
------------------------------------
Before being checked in the new classes in this patch need javadoc. There
should be class level comments on all the new classes, particularly the new
abstract classes, that explains where they fit in the class tree and what they
do. New methods in these classes that aren't overriding super class methods
need javadoc too.
I don't understand the distinction between Default*Container and
File*Container. Perhaps the javadocs requested above will resolve this.
FileOutputFormat is a bad name for the default file handling output format,
since a very well known class of that name exists already in MapReduce. It
should be called HCatFileOutputFormat for clarity.
> Refactor HCatalog to support non-filebased outputformats
> --------------------------------------------------------
>
> Key: HCATALOG-60
> URL: https://issues.apache.org/jira/browse/HCATALOG-60
> Project: HCatalog
> Issue Type: Sub-task
> Affects Versions: 0.3
> Reporter: Francis Liu
> Assignee: Francis Liu
> Labels: hbase, refactoring
> Attachments: HCatalog-60.patch, HCatalog-60_rev2.patch,
> HCatalog-60_rev3.patch, HCatalog-60_rev4.patch
>
>
> Some table sources have no need for paths (ie HBase) and thus
> JobInfo.location may be null. Looks like commitJob was trying to do a test
> before acting on the location but buggy. abortJob does not have such check.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
