----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2582/#review2921 -----------------------------------------------------------
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java <https://reviews.apache.org/r/2582/#comment6537> hbase.client.scanner.caching is the value used in hbase. can you switch to hcat.hbase.client.scanner.caching? /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java <https://reviews.apache.org/r/2582/#comment6538> Maybe change your variable to be a HBaseSerDeResultConverter so you don't have to do any casting. /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java <https://reviews.apache.org/r/2582/#comment6539> Why not handle errors? If an error happens it should be handled or sent up the chain. /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java <https://reviews.apache.org/r/2582/#comment6542> Why is this needed? /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java <https://reviews.apache.org/r/2582/#comment6540> Is it always index 0? What if my mapping is cf:,:key? /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java <https://reviews.apache.org/r/2582/#comment6541> Should change to throw the whole exception. - David On 2011-10-26 22:54:36, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2582/ > ----------------------------------------------------------- > > (Updated 2011-10-26 22:54:36) > > > Review request for hcatalog, Francis Liu and David Capwell. > > > Summary > ------- > > The current input storage driver for HBase does not use columns of the output > schema for projection. The output columns should be used to read only those > specific columns from HBase. > > > This addresses bug hcatalog-143. > https://issues.apache.org/jira/browse/hcatalog-143 > > > Diffs > ----- > > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java > 1182480 > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java > 1182480 > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java > 1182480 > > /trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java > 1182480 > > Diff: https://reviews.apache.org/r/2582/diff > > > Testing > ------- > > Unit test updates and test passes. > > > Thanks, > > Vandana > >
